Skip to content

Improve default permissions for raw artifacts#144

Open
ofek wants to merge 1 commit into
facebook:mainfrom
ofek:improve-default-perms
Open

Improve default permissions for raw artifacts#144
ofek wants to merge 1 commit into
facebook:mainfrom
ofek:improve-default-perms

Conversation

@ofek

@ofek ofek commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #107.

This changes the fallback mode for single-file artifacts on Unix from owner-executable only to all-users executable.

Validation on my Windows machine:

❯ $env.RUSTFLAGS = "-Awarnings"
❯ cargo fmt --check --quiet
❯ cargo test --quiet

running 48 tests
................................................
test result: ok. 48 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s


running 43 tests
...........................................
test result: ok. 43 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.09s
❯ devcontainer exec --workspace-folder . --remote-env $"RUSTFLAGS=($env.RUSTFLAGS)" cargo test --quiet

running 49 tests
.................................................
test result: ok. 49 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s


running 44 tests
............................................
test result: ok. 44 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.07s
❯ devcontainer exec --workspace-folder . cargo clippy --quiet -- $env.RUSTFLAGS
❯

@meta-cla meta-cla Bot added the cla signed label Jun 19, 2026
@meta-codesync

meta-codesync Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This pull request has been imported. If you are a Meta employee, you can view this in D109112264. (Because this pull request was imported automatically, there will not be any future comments.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undesirable default file permissions

1 participant